Unbreak non-x86 build on FreeBSD #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error[E0432]: unresolved import `self::arm::check_for`
--> src/libstd/../stdarch/crates/std_detect/src/detect/os/freebsd/mod.rs:11:17
|
11 | pub use self::arm::check_for;
| ^^^^^^^^^^^^^^^^^^^^ no `check_for` in `std_detect::detect::os::arm`
error[E0425]: cannot find value `detect_features` in module `self::os`
--> src/libstd/../stdarch/crates/std_detect/src/detect/mod.rs:121:37
|
121 | cache::test(x as u32, self::os::detect_features)
| ^^^^^^^^^^^^^^^ not found in `self::os`
|
help: possible candidate is found in another module, you can import it into scope
|
20 | use crate::std_detect::detect::os::arm::detect_features;
|
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
|
Does this need to be backported to stable? |
|
Thanks. We patched it locally, but it would be nice if we could drop this patch again when Rust 1.44.0 (or 1.43.1 if there is one) is released. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2020
Update stdarch submodule Includes : - rust-lang/stdarch#849 which stabilizes the remaining x86 features for feature detection. - rust-lang/stdarch#850 which fixes building stdarch on FreeBSD. Fixes rust-lang#71473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed by: 9fad964
Found during Rust 1.43.0 package update: https://reviews.freebsd.org/D24521
Submitted by: @MikaelUrankar